Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): adding support to cpu.weight #719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lubinszARM
Copy link
Contributor

What type of PR is this?

Features

What this PR does / why we need it:

We need to promote some cgroup's cpu.weight

Which issue(s) this PR fixes:

Some system cgroups can't work well due to high cpu pressure.

Special notes for your reviewer:

None

@lubinszARM lubinszARM force-pushed the pr_system_weight branch 4 times, most recently from 0a5790f to 7585be3 Compare November 13, 2024 03:52
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 28 lines in your changes missing coverage. Please review.

Project coverage is 55.95%. Comparing base (3269ac6) to head (6086086).

Files with missing lines Patch % Lines
...-plugins/cpu/handlers/cpuweight/cpuweight_linux.go 64.44% 13 Missing and 3 partials ⚠️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 0.00% 8 Missing ⚠️
cmd/katalyst-agent/app/options/qrm/cpu_plugin.go 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   55.80%   55.95%   +0.15%     
==========================================
  Files         594      595       +1     
  Lines       67830    67893      +63     
==========================================
+ Hits        37850    37990     +140     
+ Misses      25956    25876      -80     
- Partials     4024     4027       +3     
Flag Coverage Δ
unittest 55.95% <55.55%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lubinszARM lubinszARM force-pushed the pr_system_weight branch 13 times, most recently from 596a871 to 6c0ea3d Compare November 14, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant